Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?

Andres Freund <andres@anarazel.de> writes:
> I'm inclined to put back the
>            LockBuffer(buf, BUFFER_LOCK_UNLOCK);
>            LockRelationForExtension(onerel, ExclusiveLock);
>            UnlockRelationForExtension(onerel, ExclusiveLock);
>            LockBufferForCleanup(buf);
>            if (PageIsNew(page))
> dance regardless, just to get the buildfarm to green?

The buildfarm's got half a dozen reports now of a failure of this ilk,
so you'd better do something.

> But I do wonder if we should just make hio.c cope with this instead.

Probably should not try to go that way under time presssure.

            regards, tom lane