Re: [BUGS] BUG #2401: spinlocks not available on amd64

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: [BUGS] BUG #2401: spinlocks not available on amd64
Дата
Msg-id
26185.1146339268@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Re: [BUGS] BUG #2401: spinlocks not available on amd64 Tom Lane <tgl@sss.pgh.pa.us>
Theo Schlossnagle  writes:
> I'd remind everyone that the spinlock stuff is entirely optional at 
> build time.

Not really.  The performance hit for not having hardware spinlocks is
so severe that it's not considered a reasonable fallback.

> I also think it immensely useful to replace all of the tas subsystem 
> with cas so that one could reliabily lock these atomics with the process 
> id of the locker.

I cannot, ever once in my years working on Postgres, remember having
wanted such a thing.  I am strongly against mucking with the spinlock
code for mere aesthetics --- it's too fragile and hard to test,
especially on platforms you don't have ready access to.

In short, it ain't broken and we don't need to fix it.

			regards, tom lane
В списке pgsql-patches по дате отправления
От: Martijn van Oosterhout
Дата:
От: Tom Lane
Дата:
FAQ