Re: [HACKERS] snprintf causes regression tests to fail

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] snprintf causes regression tests to fail
Дата
Msg-id 25924.1109624284@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [HACKERS] snprintf causes regression tests to fail  (Bruce Momjian <pgman@candle.pha.pa.us>)
Ответы Re: [HACKERS] snprintf causes regression tests to fail
Список pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Ah, the problem was introduced here:

Right, it was my fault.

> The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
> below the printf 64-bit tests.  This commited patch moves
> PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
> just before printf 64-bit args are tested.

This patch breaks things in a different way: you should not have moved
the AC_LIBOBJ(snprintf) step.  Also you randomly placed the arg-control
test between a chunk of code and the comment describing same.

Corrected version committed.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: [HACKERS] snprintf causes regression tests to fail
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: [HACKERS] snprintf causes regression tests to fail