On 5/6/21 12:59 AM, Andres Freund wrote:
> Hi,
>
> On 2021-05-06 00:18:12 -0400, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> I understand why we don't want to rely on sed because of windows - but
>>> it's far from obvious why we can't just use the .pl variant all the
>>> time?
>> Perl is not considered a hard build requirement on non-Windows.
> Oops, forgot that.
>
>
>> We could dodge that by shipping a pre-built dummy probes.h,
>> but that doesn't really seem like a cleaner way than what's
>> there now.
> I tried to regenerate Gen_dummy_probes.pl using s2p - which doesn't seem
> to exist for modern versions of perl anymore :(
>
>
>> Also, as I read it, Gen_dummy_probes.sed is useful in any case as
>> being the "source code" for Gen_dummy_probes.pl. You'd need some
>> other form of documentation if you removed it.
I suggest we add a README that sets out
a) why we do things this way
b) that the sed script is what's authoritative
c) how to regenerate the perl script if you change the sed script,
including where to get s2p
I can do that.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com