Re: [PATCH] btree_gist: fix union implementation for variable length columns

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] btree_gist: fix union implementation for variable length columns
Дата
Msg-id 21877.1531158119@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] btree_gist: fix union implementation for variable length columns  (Pavel Raiskup <praiskup@redhat.com>)
Ответы Re: [PATCH] btree_gist: fix union implementation for variable length columns  (Pavel Raiskup <praiskup@redhat.com>)
Список pgsql-hackers
Pavel Raiskup <praiskup@redhat.com> writes:
> while I tried to debug 'gcc -fstack-protector -O3' problems in [1], I noticed
> that gbt_var_union() mistreats the first vector element.  Patch is attached.

Hi Pavel!  For patches that purport to resolve bugs, we usually like to
add a regression test case that demonstrates the bug in unpatched code.
Can you provide a small test case that does so?  (The BZ you pointed to
doesn't seem to address this...)

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: Locking B-tree leafs immediately in exclusive mode
Следующее
От: Andrey Borodin
Дата:
Сообщение: Re: [HACKERS] [PATCH] kNN for SP-GiST