Robert Haas <robertmhaas@gmail.com> writes:
>> Yeah, this is grotty. �It appears that the comment introducing
>> ExecReScan() is somewhat incorrect. �It asserts that exprCtxt is used
>> only
> Sigh.
> ...is used only for index scans. However, it's actually also used for
> bitmap scans (both heap and index) and TID scans.
Yeah, the comment was probably correct when written.
> Also, there appears
> to be an effort by nodes that don't use exprCtxt directly to propagate
> down through the node tree, which doesn't seem to make much sense if
> this is only intended to be used on the inner side of a nestloop.
That's just dead code, which is a good thing because the coverage is
pretty incomplete.
regards, tom lane