Re: Tarball builds in the new world order

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Tarball builds in the new world order
Дата
Msg-id 202404281916.cpngjkjnosj2@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Tarball builds in the new world order  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Tarball builds in the new world order  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2024-Apr-26, Tom Lane wrote:

> --- mk-one-release.orig    2024-04-23 17:30:08.983226671 -0400
> +++ mk-one-release    2024-04-26 15:17:29.713669677 -0400
> @@ -39,13 +39,17 @@ mkdir pgsql
>  git archive ${gitref} | tar xf - -C pgsql
>  
>  # Include the git ref in the output tarballs
> +# (This has no effect with v17 and up; instead we rely on "git archive"
> +# to include the commit hash in the tar header)
>  echo ${gitref} >pgsql/.gitrevision

Why is it that the .gitrevision file is only created here, instead of
being added to the tarball that "git archive" produces?  Adding an
argument like
    --add-virtual-file $(distdir)/.gitrevision:$(GIT_REFSPEC)

to the git archive call should suffice.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I can't go to a restaurant and order food because I keep looking at the
fonts on the menu.  Five minutes later I realize that it's also talking
about food" (Donald Knuth)



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: DROP OWNED BY fails to clean out pg_init_privs grants
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Refactoring backend fork+exec code