On Fri, Apr 01, 2022 at 10:00:08PM +1300, David Rowley wrote:
> 0002:
> This modifies the tuplesort API so that instead of having a
> randomAccess bool flag, this is changed to a bitwise flag that we can
> add further options in the future. It's slightly annoying to break
> the API, but it's not exactly going to be hard for people to code
> around that.
For what it's worth, the three PGXN extensions using tuplesort_begin_* are
"citus", "pg_bulkload", and "vector". Nothing calls tuplesort_set_bound().
This (commit 77bae39) did not change function parameter counts, and
TUPLESORT_RANDOMACCESS generally has same the same numeric value as "true". I
get no warning if I pass "true" for the "sortopt" flags parameter. Hence, I
suspect this did not break the API. Should we be happy about that? I'm fine
with it.