Re: Pointer subtraction with a null pointer

Поиск
Список
Период
Сортировка
Искать
От
Andres Freund
Тема
Re: Pointer subtraction with a null pointer
Дата
Msg-id
20220326184147.dhkoghv52kkfrpi4@alap3.anarazel.de
Ответ на
Список
Дерево обсуждения
Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Isaac Morland <isaac.morland@gmail.com>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Andres Freund <andres@anarazel.de>
Re: Pointer subtraction with a null pointer Tom Lane <tgl@sss.pgh.pa.us>
Hi,

On 2022-03-26 14:13:56 -0400, Tom Lane wrote:
> The attached also silences the warning, and getting rid of the double-eval
> hazard seems like a net win.

Looks good wrt relptr_store. Maybe we should fix the double-eval hazard in
relptr_access too, think that'd be only one left over...


> > Might also be worth adding an assertion that base < val.
> 
> Did that too.  On the whole I like this better.

Better than the relptr_store_null() approach I assume? Agreed, if so.

Greetings,

Andres Freund


В списке pgsql-hackers по дате отправления
От: Robert Haas
Дата:
От: Tom Lane
Дата:
FAQ