Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal

Поиск
Список
Период
Сортировка
От Julien Rouhaud
Тема Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal
Дата
Msg-id 20220227115526.vhpfhlinbruax5ky@jrouhaud
обсуждение исходный текст
Ответ на pg_stat_statements: remove redundant function call in pg_stat_statements_internal  (Dong Wook Lee <sh95119@gmail.com>)
Ответы Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

On Sun, Feb 27, 2022 at 08:45:13PM +0900, Dong Wook Lee wrote:
> 
> I found some redundant function calls in
> pg_stat_statements.c/pg_stat_statements_internal(),
> There is no need to call GetUserId() again because the value was
> previously obtained.

Indeed.  I doubt it will make any real difference but it doesn't hurt to fix
it.

Patch looks good to me.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dong Wook Lee
Дата:
Сообщение: pg_stat_statements: remove redundant function call in pg_stat_statements_internal
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: PATCH: add "--config-file=" option to pg_rewind