Re: adding 'zstd' as a compression algorithm

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: adding 'zstd' as a compression algorithm
Дата
Msg-id 20220218013612.2fpzbbb7wnfogblj@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: adding 'zstd' as a compression algorithm  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: adding 'zstd' as a compression algorithm  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

On 2022-02-17 13:34:08 +0900, Michael Paquier wrote:
> %define needs to include HAVE_LIBZSTD, HAVE_ZSTD_H and USE_ZSTD, so
> this version fails the sanity check between pg_config.h.in and the
> MSVC scripts checking that all flags exist.

Do we really need all three defines? How about using AC_CHECK_HEADER() instead
of AC_CHECK_HEADERS()? That wouldn't define HAVE_ZSTD_H. Cases where we error
out if a header isn't found make it a bit pointless to then still define
HAVE_*_H.  Plenty other cases in configure.ac just use AC_CHECK_HEADER.

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Small and unaffected typo in pg_logical_slot_get_changes_guts()
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: Support escape sequence for cluster_name in postgres_fdw.application_name