On Fri, May 14, 2021 at 07:50:13PM -0400, Alvaro Herrera wrote:
> +++ b/doc/src/sgml/config.sgml
> @@ -7643,7 +7643,12 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
> identifier to be computed. Note that an external module can
> alternatively be used if the in-core query identifier computation
> method is not acceptable. In this case, in-core computation
> - must be disabled. The default is <literal>off</literal>.
> + must be always disabled.
> + Valid values are <literal>off</literal> (always disabled),
> + <literal>on</literal> (always enabled) and <literal>auto</literal>,
> + which let modules such as <xref linkend="pgstatstatements"/>
> + automatically enable it.
> + The default is <literal>auto</literal>.
which lets
> +/* True when a module requests query IDs and they're set auto */
> +bool query_id_enabled = false;
Does "they're" mean the GUC compute_query_id ?
> +/*
> + * This should only be called if IsQueryIdEnabled()
> + * return true.
> + */
> JumbleState *
> JumbleQuery(Query *query, const char *querytext)
Should it Assert() that ?
Maybe you should update this too ?
doc/src/sgml/release-14.sgml