Re: Some doubious error messages and comments

Поиск
Список
Период
Сортировка
От Kyotaro Horiguchi
Тема Re: Some doubious error messages and comments
Дата
Msg-id 20210514.150639.2103692072548526009.horikyota.ntt@gmail.com
обсуждение исходный текст
Ответ на Some doubious error messages and comments  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers
At Mon, 10 May 2021 15:52:15 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> On Wed, Apr 28, 2021 at 08:11:47AM -0500, Justin Pryzby wrote:
> > On Wed, Apr 28, 2021 at 05:36:33PM +0900, Kyotaro Horiguchi wrote:
> >> 0001: I found some typos in a error message and a comment.
> >> 
> >> multirangetypes.c: 1420
> >> > errmsg("range_intersect_agg must be called with a multirange")));
> >> 
> >> This "range_intersect_agg" looks like a typo of "multirange_..".
> >> 
> >> operatorcmds.c:303
> >> > * Look up a join estimator function ny name, and verify that it has the
> >> 
> >> "ny" looks like a typo of "by".
> > 
> > "ny name" shows up a 2nd time.
> > 
> > I have another "comment typos" patch - maybe someone will want to push them
> > together.
> 
> Thanks.  Two of them were already fixed, two of them are correct but
> went missing so I have applied a fix for these.  The change in

Thanks.

> multirange_intersect_agg_transfn() is incorrect as the error refers to
> the SQL function range_intersect_agg().

Uh!! It seems to be a never-shown message.  Thaks for checking that.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Support for VACUUMing Foreign Tables
Следующее
От: Dilip Kumar
Дата:
Сообщение: Re: Support for VACUUMing Foreign Tables