Re: [Patch] Make pg_checksums skip foreign tablespace directories

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [Patch] Make pg_checksums skip foreign tablespace directories
Дата
Msg-id 20200223070858.GB1792@paquier.xyz
обсуждение исходный текст
Ответ на Re: [Patch] Make pg_checksums skip foreign tablespace directories  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Ответы Re: [Patch] Make pg_checksums skip foreign tablespace directories  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Fri, Feb 21, 2020 at 05:37:15PM +0900, Kyotaro Horiguchi wrote:
> The two str[n]cmps are different only in matching length. I don't
> think we don't need to differentiate the two message there, so we
> could reduce the code as:
>
> | cmplen = strlen(excludeFiles[].name);
> | if (!prefix_patch)
> |   cmplen++;
> | if (strncmp(d_name, excludeFilep.name, cmplen) == 0)
> |   ...

Good idea.  Let's do things as you suggest.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Shay Rojansky
Дата:
Сообщение: Re: Error on failed COMMIT
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: [Patch] Make pg_checksums skip foreign tablespace directories