Re: proposal: minscale, rtrim, btrim functions for numeric
| От | Karl O. Pinc |
|---|---|
| Тема | Re: proposal: minscale, rtrim, btrim functions for numeric |
| Дата | |
| Msg-id | 20191210065633.333b36e2@slate.karlpinc.com обсуждение |
| Ответ на | Re: proposal: minscale, rtrim, btrim functions for numeric (Pavel Stehule <pavel.stehule@gmail.com>) |
| Ответы |
Re: proposal: minscale, rtrim, btrim functions for numeric
|
| Список | pgsql-hackers |
On Tue, 10 Dec 2019 07:11:59 +0100
Pavel Stehule <pavel.stehule@gmail.com> wrote:
> út 10. 12. 2019 v 0:03 odesílatel Karl O. Pinc <kop@meme.com> napsal:
> > I also wonder whether all the trim_scale() tests
> > are now necessary, but not enough to make any suggestions.
> I don't think so tests should be minimalistic - there can be some
> redundancy to coverage some less probable size effects of some future
> changes. More - there is a small symmetry with min_scale tests - and
> third argument - some times I use tests (result part) as
> "documentation".
Fine with me.
Tests pass against HEAD. Docs build and look good.
Patch looks good to me.
I'm marking it ready for a committer.
Thanks for the work.
Regards,
Karl <kop@meme.com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
В списке pgsql-hackers по дате отправления: