Re: pg_wal/RECOVERYHISTORY file remains after archive recovery

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery
Дата
Msg-id
20190930080340.GO2888@paquier.xyz
Ответ на
Список
Дерево обсуждения
pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Fujii Masao <masao.fujii@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Michael Paquier <michael@paquier.xyz>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Fujii Masao <masao.fujii@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Michael Paquier <michael@paquier.xyz>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Fujii Masao <masao.fujii@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Michael Paquier <michael@paquier.xyz>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Michael Paquier <michael@paquier.xyz>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Michael Paquier <michael@paquier.xyz>
Re: pg_wal/RECOVERYHISTORY file remains after archive recovery Masahiko Sawada <sawada.mshk@gmail.com>
On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> I think that the above checks are always true because isnt() function
> checks if the 1st argument and 2nd argument are not the same.

Dammit.  I overlooked this part of the module's doc.

> I've attached the updated version patch including the tests. Please
> review it.

Thanks, your test allows to reproduce the original problem, so that's
nice.  I don't have much to say, except some improvements to the
comments of the test as per the attached.  What do you think?
--
Michael
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата:
От: Masahiko Sawada
Дата:
FAQ