Re: FETCH FIRST clause PERCENT option
От
Kyotaro Horiguchi
Тема
Re: FETCH FIRST clause PERCENT option
Дата
Msg-id
20190927.095919.206703929.horikyota.ntt@gmail.com
Ответ на
Re: FETCH FIRST clause PERCENT option (Ryan Lambert)
Список
Дерево обсуждения
FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Andres Freund <andres@anarazel.de>
Re: FETCH FIRST clause PERCENT option Mark Dilger <hornschnorter@gmail.com>
Re: FETCH FIRST clause PERCENT option Andres Freund <andres@anarazel.de>
Re: FETCH FIRST clause PERCENT option Mark Dilger <hornschnorter@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Mark Dilger <hornschnorter@gmail.com>
Re: FETCH FIRST clause PERCENT option Mark Dilger <hornschnorter@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Vik Fearing <vik.fearing@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Vik Fearing <vik.fearing@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Re: FETCH FIRST clause PERCENT option David Steele <david@pgmasters.net>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Andres Freund <andres@anarazel.de>
Re: FETCH FIRST clause PERCENT option Tom Lane <tgl@sss.pgh.pa.us>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Thomas Munro <thomas.munro@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Erik Rijkers <er@xs4all.nl>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Erik Rijkers <er@xs4all.nl>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Tom Lane <tgl@sss.pgh.pa.us>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Vik Fearing <vik.fearing@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Michael Paquier <michael@paquier.xyz>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Jaime Casanova <jcasanov@systemguards.com.ec>
Re: FETCH FIRST clause PERCENT option David Steele <david@pgmasters.net>
Re: FETCH FIRST clause PERCENT option Jaime Casanova <jcasanov@systemguards.com.ec>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Ryan Lambert <ryan@rustprooflabs.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause PERCENT option Tom Lane <tgl@sss.pgh.pa.us>
Re: FETCH FIRST clause PERCENT option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause PERCENT option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Andres Freund <andres@anarazel.de>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Erik Rijkers <er@xs4all.nl>
Re: FETCH FIRST clause PERCENT option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause PERCENT option Thomas Munro <thomas.munro@enterprisedb.com>
At Thu, 26 Sep 2019 15:13:42 -0600, Ryan Lambert wrote in > On Thu, Sep 19, 2019 at 6:52 AM Surafel Temesgen > wrote: > > > Hi Tom, > > In the attached patch i include the comments given > > > > regards > > Surafel > > > > Patch v9 applies and passes make installcheck-world. > > > From: Tom Lane > > Date: 2019-09-05 22:26:29 > > > * I didn't really study the changes in nodeLimit.c, but doing > > "tuplestore_rescan" in ExecReScanLimit is surely just wrong. You > > probably want to delete and recreate the tuplestore, instead, since > > whatever data you already collected is of no further use. Maybe, in > > the case where no rescan of the child node is needed, you could re-use > > the data already collected; but that would require a bunch of additional > > logic. I'm inclined to think that v1 of the patch shouldn't concern > > itself with that sort of optimization. > > I don't think this was addressed. It seems to me that Tom is suggesting to conisider that kind of optimization after once completing the patch without it. (That in the first patch was just wrong, but more stuff is needed to achieve that.) regards. -- Kyotaro Horiguchi NTT Open Source Software Center
В списке pgsql-hackers по дате отправления
От: Alvaro Herrera
Дата: