Re: REINDEX filtering in the backend

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: REINDEX filtering in the backend
Дата
Msg-id
20190828050951.GH1965@paquier.xyz
Ответ на
Список
Дерево обсуждения
REINDEX filtering in the backend Julien Rouhaud <rjuju123@gmail.com>
Re: REINDEX filtering in the backend Michael Paquier <michael@paquier.xyz>
Re: REINDEX filtering in the backend Michael Paquier <michael@paquier.xyz>
Re: REINDEX filtering in the backend Julien Rouhaud <rjuju123@gmail.com>
Re: REINDEX filtering in the backend Michael Paquier <michael@paquier.xyz>
Re: REINDEX filtering in the backend Julien Rouhaud <rjuju123@gmail.com>
Re: REINDEX filtering in the backend Michael Paquier <michael@paquier.xyz>
Re: REINDEX filtering in the backend Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: REINDEX filtering in the backend Michael Paquier <michael@paquier.xyz>
On Wed, Aug 28, 2019 at 02:02:08PM +0900, Michael Paquier wrote:
> +       index = index_open(indexOid, AccessShareLock);
> +       numAtts = index->rd_index->indnatts;
> +       index_close(index, AccessShareLock);
> Wouldn't it be better to close that after doing the scan?
> 
> Nit: I am pretty sure that this should be indented.
> 
> Could you add tests with REINDEX CONCURRENTLY?

Bonus: support for reindexdb should be added.  Let's not forget about
it.
--
Michael
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Fabien COELHO
Дата:
FAQ