Re: Unused parameters & co in code

On Thu, Jan 31, 2019 at 03:47:59PM +0900, Michael Paquier wrote:
> - 0001 cleans up port in SendAuthRequest.  This one is disappointing,
> so I am fine to discard it.
> - 0002 works on _bt_relbuf, whose callers don't actually benefit from
> the cleanup as the relation worked on is always used for different
> reasons, so it can be discarded.
> - 0003 works on the code of GIN, which simplifies at least the code,
> so it could be applied.  This removes more than changed.
> - 0004 also cleans some code for clause parsing, with a negative line
> output.
> - 0005 is for pg_rewind, which is some stuff I introduced, so I'd like
> to clean up my mess and the change is recent :)
> - 0006 is for tablecmds.c, and something I would like to apply because
> it reduces some confusion with some recursion arguments which are not
> needed for constraint handling and inheritance.  Most of the complains
> come from lockmode not being used but all the AtPrep and AtExec
> routines are rather symmetric so I am not bothering about that.

A note for the archives: I have committed 0005 as 6e52209e because it
was directly something I worked on.  I have dropped the rest as I am
not clear if all those arguments can be useful for future use or not.
--
Michael