On Tue, Jul 10, 2018 at 12:26:30AM -0700, Andres Freund wrote:
> Why is the ReplicationSlotRelease() needed here? Souldn't the error
> handling code do so automatically?
Oh, indeed. I didn't know that PostgresMain was doing some cleanup
here. There is a second place where this can be removed, which comes
from the original commit which added the advance function. An updated
version is attached. Do you have other comments?
--
Michael