Re: Non-reserved replication slots and slot advancing

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Non-reserved replication slots and slot advancing
Дата
Msg-id 20180709064833.GB30202@paquier.xyz
обсуждение исходный текст
Ответ на Re: Non-reserved replication slots and slot advancing  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Ответы Re: Non-reserved replication slots and slot advancing  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Re: Non-reserved replication slots and slot advancing  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
On Mon, Jul 09, 2018 at 03:13:04PM +0900, Kyotaro HORIGUCHI wrote:
> Looking the attached patch, I noticed that both "WAL" and "wal"
> are used in similar ERROR messages. Grepping the source tree
> showed me that it is always in upper case letters except in the
> case it is a part of other words like variable/column/function
> names or "walsender". This is the same with the word "lsn".

Thanks for the lookup.

I see.  Indeed, let's fix at the same time the error message close by.
xlog.c uses "WAL location (LSN)" for the same thing, so I am sticking
with that as per the attached.  I'll go commit that if there are no
objections.  If you see any others which you would like to fix, please
feel free to send a patch.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Markus Wanner
Дата:
Сообщение: Re: How can we submit code patches that implement our (pending)patents?
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Possible bug in logical replication.