Re: Speedup of relation deletes during recovery

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Speedup of relation deletes during recovery
Дата
Msg-id 20180703022817.GH2159@paquier.xyz
обсуждение исходный текст
Ответ на Re: Speedup of relation deletes during recovery  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Speedup of relation deletes during recovery
Список pgsql-hackers
On Tue, Jul 03, 2018 at 04:13:15AM +0900, Fujii Masao wrote:
> OK, so what about the attached patch?

I have been looking at this patch, and this looks in good shape to me
(please indent!).

+    * Call smgrclose() in reverse order as when smgropen() is called.
+    * This trick enables remove_from_unowned_list() in smgrclose()
+    * to search the SMgrRelation from the unowned list,
+    * in O(1) performance.

A nit here: with O(1) performance.

Could it be possible to add an assertion so as isRedo is never enabled
out of recovery?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jaime Casanova
Дата:
Сообщение: Re: automatic restore point
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Unexpected behavior of DROP VIEW/TABLE IF EXISTS