On Wed, Jun 13, 2018 at 09:07:20AM +0900, Michael Paquier wrote:
> What kind of failures are you seeing? I just compiled Postgres two days
> ago with MSVC and OpenSSL 1.0.2o (oldest version with a Windows
> installer I could find), and that was able to compile. On HEAD, OpenSSL
> should be supported down to 0.9.8. This thread discusses about whether
> we want to enforce HAVE_X509_GET_SIGNATURE_NID unconditionally or not,
> as it is disabled now. Even if the code is linked to 1.0.2 and the flag
> is not set, then the code should be able to compile.
So, I was looking at this part this morning, and I would suggest the
attached, which enables HAVE_X509_GET_SIGNATURE_NID and
HAVE_SSL_CLEAR_OPTIONS, raising the bar to have at least OpenSSL 1.0.2
on Windows (that's the minimum version easily findable when it comes to
MSI installers anyway these days). I have checked that the code is able
to compile correctly as well.
HAVE_LDAP_INITIALIZE is added in the list, but this is disabled as I
could not test it. It could always be possible to revisit that later.
Thomas, what do you think?
Thoughts?
--
Michael