Re: [HACKERS] valgrind vs. shared typmod registry

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: [HACKERS] valgrind vs. shared typmod registry
Дата
Msg-id 20170919005607.og6pdhi7vn3qhrm6@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: [HACKERS] valgrind vs. shared typmod registry  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
Hi,

On 2017-09-18 18:04:36 +1200, Thomas Munro wrote:
> On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
> > Here is a patch to fix that.
> 
> Here's a better one (same code, corrected commit message).

Pushed. For a second I was tempted to also replace the
palloc(sizeof(dshash_table)) with a palloc0 - but in the end it seems
actually not too bad either to be able to catch bugs like this with some
help. If you have a strong opinion either way...

Thanks,

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [HACKERS] Boom filters for hash joins (was: A design for amcheckheapam verification)
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: [HACKERS] Small code improvement for btree