Andres Freund wrote:
> We currently still have the guideline that code should fit into an 80
> character window. But an increasing amount of the code, and code
> submissions, don't adhere to that (e.g. copy.c, which triggered me to
> write this email). And I mean outside of accepted "exceptions" like
> error messages. And there's less need for such a relatively tight limit
> these days. Perhaps we should up the guideline to 90 or 100 chars?
I'd rather keep the existing limit, and enforce it more strongly.
With the recent pgindent changes, it's no longer possible to save a few
chars by moving the first (or any) argument of a function to a separate
line; in some cases, we're now forced to make function arguments shorter
in order to meet the 80-char standard. In many cases that means adding
a variable declaration with a short name and a separate assignment.
That seems acceptable to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services