[HACKERS] Re: [COMMITTERS] pgsql: Preventive maintenance in advance ofpgindent run.

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема [HACKERS] Re: [COMMITTERS] pgsql: Preventive maintenance in advance ofpgindent run.
Дата
Msg-id 20170517140847.lasiafwmsxgzppm6@alvherre.pgsql
обсуждение исходный текст
Ответы Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Tom Lane wrote:

> src/bin/pg_basebackup/pg_basebackup.c          | 24 +++++++++---------
> src/bin/pg_waldump/pg_waldump.c                | 18 ++++++-------

There are some changes here that should be reverted; for instance:

-   printf(_("  -c, --checkpoint=fast|spread\n"
-            "                         set fast or spread checkpointing\n"));
+   printf(_("  -c, --checkpoint=fast|spread\n"));
+   printf(_("                         set fast or spread checkpointing\n"));

From the translator's point of view the patched version doesn't make
sense because they are two separate strings.  In the original, it's a
single translatable string.  Particularly in pg_waldump's -p, where a
phrase is now cut in the middle.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashutosh Bapat
Дата:
Сообщение: Re: [HACKERS] [POC] hash partitioning
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.