On 2015-10-21 17:21:25 -0300, Alvaro Herrera wrote:
> > It seems that the 2nd assignment was an oversight. Spotted by Bernd
> > Helmle.
Yea, that's obviously redudant. Will remove.
> I think the first assignment is also pointless -- I mean can't we just
> use MyReplicationSlot->data.name in both places where slot_name is used?
Makes the lines a bit long. strlen(NameStr(MyReplicationSlot->data.name)) ...
> In the same routine, it seems wasteful to be doing strlen() twice for
> every string sent over the wire.
That seems fairly insignificant. For one this is a rather infrequent and
expensive operation, for another every decent compiler can optimize
those away. Note that those duplicate strlen() calls are there in a lot
of places in walsender.c
Greetings,
Andres Freund