> On 9/4/2015 2:04 PM, Tatsuo Ishii wrote:
>>> One thing I imagine we could do is to change the signature of
>>> summrize_range() to also include heapNumBlks which its (only) caller
>>> brinsummarize() already computes. It will look like:
>>>
>>> static void summarize_range(IndexInfo *indexInfo, BrinBuildState *state,
>>> Relation heapRel,
>>> BlockNumber heapBlk,
>>> BlockNumber heapNumBlks);
>>>
>>> I'd think changing summarize_range()'s signature would be relatively
>>> easier/safer.
>>
>> Yeah, sounds good.
>
> Here's a patch to do that.
Thanks. It looks good to me (and passed all the regression tests in
master branch). I will commit your patch if there's no objection.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp