On Mon, Aug 03, 2015 at 01:32:10AM +0000, Kouhei Kaigai wrote:
> > On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> > > I observed these inconsistencies in node support functions:
> >
> > A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
> > INT/UINT or field order corrections. The non-cosmetic changes involve
> > CustomPath, CustomScan, and CreatePolicyStmt. Feature committers, if the
> > existing treatments (ignore custom_plans/custom_paths fields; copy/compare
> > "cmd" string pointer as a scalar) were deliberate, please let me know.
> >
> Thanks for your works.
>
> I also noticed one other inconsistent point; _outMergeJoin() dumps
> mergeNullsFirst[] array but it does not use booltostr() macro.
Good catch. All supported branches work that way, and it's not wrong. I
recommend keeping it unchanged.