Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()

Поиск
Список
Период
Сортировка
Искать
От
Christian Kruse
Тема
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()
Дата
Msg-id
20140129203754.GE31325@defunct.ch
Ответ на
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() (Tom Lane)
Список
Дерево обсуждения
Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndQuadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndQuadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndQuadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Andres Freund <andres@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Andres Freund <andres@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Christian Kruse <christian@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Jason Petersen <jason@citusdata.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Andres Freund <andres@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Stephen Frost <sfrost@snowman.net>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Suspicion of a compiler bug in clang: using ternary operator in ereport() Tom Lane <tgl@sss.pgh.pa.us> 
Hi,

On 29/01/14 13:39, Tom Lane wrote:
> No, what I meant is that the ereport caller needs to save errno, rather
> than assuming that (some subset of) ereport-related subroutines will
> preserve it.
> […]

Your reasoning sounds quite logical to me. Thus I did a

grep -RA 3 "ereport" src/* | less

and looked for ereport calls with errno in it. I found quite a few,
attached you will find a patch addressing that issue.

Best regards,

-- 
 Christian Kruse               http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-hackers по дате отправления
Предыдущее
От: Pavel Stehule
Дата:
Следующее
От: Christian Kruse
Дата:
FAQ