Re: ECPG, two varchars with same name on same line
От
Bruce Momjian
Тема
Re: ECPG, two varchars with same name on same line
Дата
Msg-id
201002270323.o1R3NJs24865@momjian.us
Ответ на
Re: ECPG, two varchars with same name on same line (Michael Meskes)
Список
Дерево обсуждения
ECPG, two varchars with same name on same line Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Re: ECPG, two varchars with same name on same line Michael Meskes <meskes@postgresql.org>
Re: ECPG, two varchars with same name on same line Bruce Momjian <bruce@momjian.us>
Re: ECPG, two varchars with same name on same line Michael Meskes <meskes@postgresql.org>
Re: ECPG, two varchars with same name on same line Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Re: ECPG, two varchars with same name on same line Michael Meskes <meskes@postgresql.org>
Michael Meskes wrote: > On Fri, May 01, 2009 at 03:49:47PM +0300, Heikki Linnakangas wrote: > > ECPG constructs internal struct names for VARCHAR fields using the field > > name and line number it's defined on. In a contrived example, though, > > that's not unique. Consider the following example: > > ... > > That hardly happens in practice, of course, but it's trivial to fix by > > just adding some more salt to the struct name, like a simple counter, so > > it seems we should. > > In principle you're right. However, the change needs to be added in several > places like the internal variable structure that keeps the lineno anyway but > needs to add the counter too. BTW we can remove the lineno then I think. > Anyway, given that we are close to a release and the bug apparently never got > up in a real life usage for years I'd prefer to not change it now but wait > until the release has been done. Was this fixed? -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата: