Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
>
> > > Maybe have the check-tabs rule as a dependency of the "check", "html"
> > > and/or "draft" rules?
> > >
> > > > + check-tabs:
> > > > + ( ! grep ' ' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";
exit 1)
> >
> > Uh, I didn't think people wanted to actually have any tab testing in
> > their automatically. Do they?
>
> IMO that's the point of the whole exercise.
OK, done with attached patch, now done as part of 'gmake check'. If
people want it as part of the build process, please let me know.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: Makefile
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/Makefile,v
retrieving revision 1.136
diff -c -c -r1.136 Makefile
*** Makefile 5 Feb 2010 14:51:50 -0000 1.136
--- Makefile 5 Feb 2010 19:28:14 -0000
***************
*** 263,269 ****
##
# Quick syntax check without style processing
! check: postgres.sgml $(ALMOSTALLSGML)
$(NSGMLS) $(SPFLAGS) $(SGMLINCLUDE) -s $<
--- 263,269 ----
##
# Quick syntax check without style processing
! check: postgres.sgml $(ALMOSTALLSGML) check-tabs
$(NSGMLS) $(SPFLAGS) $(SGMLINCLUDE) -s $<
***************
*** 346,352 ****
endif # sqlmansectnum != 7
check-tabs:
! ( ! grep ' ' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files"; exit
1)
##
## Clean
--- 346,352 ----
endif # sqlmansectnum != 7
check-tabs:
! @( ! grep ' ' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files"; exit
1)
##
## Clean