Re: [PATCH v2] Add bit operations util header

Поиск
Список
Период
Сортировка
Искать
От
Jeremy Kerr
Тема
Re: [PATCH v2] Add bit operations util header
Дата
Msg-id
200906032127.16906.jk@ozlabs.org
Ответ на
Список
Дерево обсуждения
faster version of AllocSetFreeIndex for x86 architecture Atsushi Ogawa <a_ogawa@hi-ho.ne.jp>
Re: faster version of AllocSetFreeIndex for x86 architecture Simon Riggs <simon@2ndQuadrant.com>
Re: faster version of AllocSetFreeIndex for x86 architecture Jeremy Kerr <jk@ozlabs.org>
[PATCH 1/2] Add bit operations util header Jeremy Kerr <jk@ozlabs.org>
Re: [PATCH 1/2] Add bit operations util header Tom Lane <tgl@sss.pgh.pa.us>
[PATCH v2] Add bit operations util header Jeremy Kerr <jk@ozlabs.org>
Re: [PATCH v2] Add bit operations util header Florian Weimer <fweimer@bfk.de>
Re: [PATCH v2] Add bit operations util header Jeremy Kerr <jk@ozlabs.org>
Re: [PATCH v2] Add bit operations util header Florian Weimer <fweimer@bfk.de>
Re: [PATCH v2] Add bit operations util header Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH v2] Add bit operations util header Jeremy Kerr <jk@ozlabs.org>
[RFC,PATCH] Avoid manual shift-and-test logic in AllocSetFreeIndex Jeremy Kerr <jk@ozlabs.org>
Re: [RFC,PATCH] Avoid manual shift-and-test logic in AllocSetFreeIndex Atsushi Ogawa <a_ogawa@hi-ho.ne.jp>
Re: [RFC,PATCH] Avoid manual shift-and-test logic in AllocSetFreeIndex Jeremy Kerr <jk@ozlabs.org>
[PATCH v2] Avoid manual shift-and-test logic in AllocSetFreeIndex Jeremy Kerr <jk@ozlabs.org>
Re: [RFC,PATCH] Avoid manual shift-and-test logic in AllocSetFreeIndex Atsushi Ogawa <a_ogawa@hi-ho.ne.jp>
Re: [RFC,PATCH] Avoid manual shift-and-test logic in AllocSetFreeIndex Jeremy Kerr <jk@ozlabs.org>
[PATCH 2/2] Use fls() to find chunk set Jeremy Kerr <jk@ozlabs.org>
Florian,

> > +#if defined(__GNUC__) && \
> > +	(defined(__ppc__) || defined(__powerpc__) || \
> > +	 defined(__ppc64__) || defined (__powerpc64__))
>
> If you require GCC anyway, you can use __builtin_clz instead.
> (It's been available since GCC 4.1 at least.)

Because now we have to test the compiler *and* the version as well?

But I do agree that using the builtins makes for much better code; I'm 
looking at a future change that does this.

Cheers,


Jeremy


В списке pgsql-hackers по дате отправления
От: Markus Wanner
Дата:
От: Florian Weimer
Дата:
FAQ