Re: float4/float8/int64 passed by value with tsearch fixup

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: float4/float8/int64 passed by value with tsearch fixup
Дата
Msg-id 20080418201924.GH572@alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: float4/float8/int64 passed by value with tsearch fixup  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: float4/float8/int64 passed by value with tsearchfixup  (Gregory Stark <stark@enterprisedb.com>)
Re: float4/float8/int64 passed by value with tsearch fixup  (Zoltan Boszormenyi <zb@cybertec.at>)
Список pgsql-patches
Tom Lane wrote:

> Specifically, I think what you missed is that on some platforms C
> functions pass or return float values differently from similar-sized
> integer or pointer values (typically, the float values get passed in
> floating-point registers).

Argh ... I would have certainly missed that.

> It'd be less ugly to convert to v1 calling convention.

Okay -- I'll change contrib/seg to v1 to greenify back the buildfarm.

> So I think we really do need to offer that compile-time option.
> Failing to do so will be tantamount to desupporting v0 functions
> altogether, which I don't think we're prepared to do.

I have asked the Cybertec guys for a patch.  Since it's basically a copy
of the float8 change, it should be easy to do.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: float4/float8/int64 passed by value with tsearch fixup
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: Testing pg_terminate_backend()