Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Дата
Msg-id 20071002062120.9A018DCC62F@svr2.hagander.net
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
> > http://www.openssl.org/docs/crypto/ERR_set_mark.html
> > says
> > ERR_set_mark() and ERR_pop_to_mark() were added in OpenSSL 0.9.8.
> 
> > Ooops.  Back to the drawing board.
> 
> To get the buildfarm going again, I applied a patch that turns these
> calls into no-ops if the local OpenSSL hasn't got the functions.
> I'm not entirely sure if the net result is a regression for pre-0.9.8
> OpenSSLs or not --- Magnus, any thoughts on that?

I think it is. With Dave's part of the patch and not mine, you get the incorrect error message. It requires that you
setsslmode to required which I did't 
 
originally note, but if you do you'll get the wrong error.

Not sure what's the least evil fix.

We could ifdef the whole fix and use the old code for earlier openssl but bio for 0.9.8. Or we could implement my other
ideato load the certificate earlier. 
 
Or we could just say live with the error message on older openssl. Or someone has another idea?

/Magnus


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeremy Drake
Дата:
Сообщение: Re: Build farm failure
Следующее
От: "Magnus Hagander"
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL