Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> You're not doing very well with this project :-(.  pg_ctl is now
> >> actively broken, because the PGDATA value passed down to the
> >> bootstrap backend is the one in the environment variable.  The
> >> previous coding canonicalized that, this does not.
>
> > I didn't think we could modify the environment variables like that
> > portably.
>
> Possibly not, but if you think that then the correct response is to
> re-assign the environment var using putenv().

Yea, but we clean up the variable on input to the backend anyway.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073