On Thu, Oct 19, 2000 at 08:55:55PM +0200, Peter Eisentraut wrote:
> Marko Kreen writes:
> > Here is a implementation of crypto hashes for PostgreSQL.
>
> > It is packaged at the moment as stand-alone package, because
> > I am trying to write general autoconf macros for use with outside
> > packages. At the moment any package author must generate those
> > himself. Also the contrib stuff should be possible to make use
> > of this instead of include ../../Makefile.* so they can enjoy
> > the same (dis)advantages as outside packages.
>
> A coupla comments:
>
> * Your code seems to be quite optimistic about being on a Linux system.
Well, it has a reason :) Anyway the autoconf stuff is alpha and
contrib patch I will send will use current makefile system,
no autoconf.
> * Use AC_DEFUN, not `define', to create Autoconf macros.
Oh. Ofcourse. I have played too much with pure m4... (I use it
for generating SQL)
> * From PostgreSQL 7.1-to-be on you can detect the location of the include
> and library files with `pg_config --includedir` and `pg_config --libdir`
> respectively.
Nice. I didn't know.
> (I've been thinking about writing a general-purpose PostgreSQL detection
> macro for use by third-party products to be included in the PostgreSQL
> source.)
Well, that happens to be my idea also :) Maybe we can, like, join
the effort?
--
marko