Re: obsolete reference to a SubPlan field

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: obsolete reference to a SubPlan field
Дата
Msg-id 199433.1647279900@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: obsolete reference to a SubPlan field  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: obsolete reference to a SubPlan field  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Feb 2, 2022 at 3:08 AM Amit Langote <amitlangote09@gmail.com> wrote:
>> Attached patch removes those.

> Looks right to me. Tom, any comments?

I'm pretty sure I left those comments alone on purpose back in 2007,
and I don't find simply removing them to be an improvement.

In principle, readers might expect that tree walkers/mutators
would descend to a SubPlan's query, as they do for a SubLink's
query.  Calling out the fact that that doesn't happen seems
useful to me.  If you don't like this particular wording of those
comments, we can discuss better wordings ... but I doubt that
nothing-at-all is better.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nathan Bossart
Дата:
Сообщение: Re: Estimating HugePages Requirements?
Следующее
От: Robert Haas
Дата:
Сообщение: Re: obsolete reference to a SubPlan field