Re: Use LN_S instead of "ln -s" in Makefile

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Use LN_S instead of "ln -s" in Makefile
Дата
Msg-id 17230.1581731167@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Use LN_S instead of "ln -s" in Makefile  (Ashwin Agrawal <aagrawal@pivotal.io>)
Список pgsql-hackers
Ashwin Agrawal <aagrawal@pivotal.io> writes:
> On Fri, Feb 14, 2020 at 4:57 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm.  So, these oversights are certainly bugs in narrow terms.  However,
>> they've all been like that for a *long* time --- the three instances
>> you found date to 2005, 2006, and 2008 according to "git blame".
>> The complete lack of complaints shows that nobody cares.  So I think
>> a fairly strong case could be made for going the other way, ie
>> s/$(LN_S)/ln -s/g and get rid of the configure-time cycles wasted in
>> setting up that variable.

> I accede to it.

Oh ... 2005 was just the last time anybody touched that particular
line in backend/Makefile.  Further digging shows that we've been
installing the postmaster -> postgres symlink with raw "ln -s"
clear back to the Postgres95 virgin sources.  I didn't bother to
chase down the oldest instances of the other two cases.

(Man, "git blame" is such a great tool for software archaeology.)

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ashwin Agrawal
Дата:
Сообщение: Re: Use LN_S instead of "ln -s" in Makefile
Следующее
От: Bryn Llewellyn
Дата:
Сообщение: jsonb_object() seems to be buggy. jsonb_build_object() is good.