Re: Correct the documentation for work_mem

Поиск
Список
Период
Сортировка
Искать
От
Tristen Raab
Тема
Re: Correct the documentation for work_mem
Дата
Msg-id
169083626116.1127.288822187162141328.pgcf@coridan.postgresql.org
Ответ на
Список
Дерево обсуждения
Correct the documentation for work_mem "Imseih (AWS), Sami" <simseih@amazon.com>
Re: Correct the documentation for work_mem Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: Correct the documentation for work_mem Tom Lane <tgl@sss.pgh.pa.us>
Re: Correct the documentation for work_mem Gurjeet Singh <gurjeet@singh.im>
Re: Correct the documentation for work_mem "Imseih (AWS), Sami" <simseih@amazon.com>
Re: Correct the documentation for work_mem "Imseih (AWS), Sami" <simseih@amazon.com>
Re: Correct the documentation for work_mem David Rowley <dgrowleyml@gmail.com>
Re: Correct the documentation for work_mem Tristen Raab <tristen.raab@highgo.ca>
Re: Correct the documentation for work_mem "Imseih (AWS), Sami" <simseih@amazon.com>
Re: Correct the documentation for work_mem Bruce Momjian <bruce@momjian.us>
Re: Correct the documentation for work_mem David Rowley <dgrowleyml@gmail.com>
Re: Correct the documentation for work_mem "Imseih (AWS), Sami" <simseih@amazon.com>
Re: Correct the documentation for work_mem David Rowley <dgrowleyml@gmail.com>
Re: Correct the documentation for work_mem Bruce Momjian <bruce@momjian.us>
Re: Correct the documentation for work_mem David Rowley <dgrowleyml@gmail.com>
Re: Correct the documentation for work_mem Bruce Momjian <bruce@momjian.us>
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            tested, passed

Hello,

I've reviewed and built the documentation for the updated patch. As it stands right now I think the documentation for this section is quite clear.

> I'm wondering about adding "and more than one of these operations may
> be in progress simultaneously".  Are you talking about concurrent
> sessions running other queries which are using work_mem too?

This appears to be referring to the "sort and hash" operations mentioned prior.

> If so,
> isn't that already covered by the final sentence in the quoted text
> above? if not, what is running simultaneously?

I believe the last sentence is referring to another session that is running its own sort and hash operations. So the first section you mention is describing how sort and hash operations can be in execution at the same time for a query, while the second refers to how sessions may overlap in their execution of sort and hash operations if I am understanding this correctly.

I also agree that changing "sort or hash" to "sort and hash" is a better description.

Tristen
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата:
От: Jeff Davis
Дата:
FAQ