Re: pgsql: Fix (some of the) breakage introduced into query-cancel

Simon Riggs <simon@2ndquadrant.com> writes:
> On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote:
>> Fix (some of the) breakage introduced into query-cancel processing by HS.

>> It is absolutely not okay to throw an ereport(ERROR) in any random place in
>> the code just because DoingCommandRead is set; interrupting, say, OpenSSL
>> in the midst of its activities is guaranteed to result in heartache.

> ...That was not introduced by HS.

Yes it was; or at least it was in your HS commit:

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.diff?r1=1.578;r2=1.579

            regards, tom lane