Re: libpq Win32 Mutex performance patch

Andrew Chernow <ac@esilo.com> writes:
> The attached patch replaces the win32 mutex calls with critical section
> calls.  The change will not affect the behavior of the windows
> pthread_xxx functions.

Why have you defined the lock/unlock functions as willing to fall
through silently if handed a null pointer?  I think a crash in
such a case is what we *want*.  Silently not locking is surely
not very safe.

            regards, tom lane