Re: some additional (small) problems with pg_combinebackup and tablespaces

> On 24 Apr 2024, at 19:59, Robert Haas <robertmhaas@gmail.com> wrote:

> Here is a very small patch correcting these regrettable errors.

Patch LGTM.

In addition to those, unless I'm reading it wrong the current coding seems to
include a "-P" short option which is missing in the command parsing switch
statement (or in the help output):

    while ((c = getopt_long(argc, argv, "dnNPo:T:",

Should that be removed?

A tiny nit-pick in the same area: while not wrong, it reads a bit odd to have
"don't" and "do not" on lines directly next to each other:

    printf(_("  -n, --dry-run             don't actually do anything\n"));
    printf(_("  -N, --no-sync             do not wait for changes to be written safely to disk\n"));

--
Daniel Gustafsson