Re: GiST seems to drop left-branch leaf tuples

Excerpts from Peter Tanski's message of mar nov 23 12:00:52 -0300 2010:

> There are checks inside the Picksplit() function for the number of entries:
> 
>   OffsetNumber maxoff = entryvec->n - 1;
>   int n_entries, j;
>   n_entries = Max(maxoff, 1) - 1;
> 
>   j = 0;
>   for (i = FirstOffsetNumber; i < maxoff; i = OffsetNumberNext(i)) {
>     FPrint* v = deserialize_fprint(entv[i].key);

Isn't this off by one?  Offset numbers are 1-based, so the maxoff
computation is wrong.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support