Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

Simon Riggs <simon@2ndQuadrant.com> writes:
> On Wed, 2010-06-23 at 21:54 +0000, Robert Haas wrote:
>> This adds four additional connection parameters to libpq: keepalives,
>> keepalives_idle, keepalives_count, and keepalives_interval.
>> keepalives default to on, per discussion, but can be turned off by
>> specifying keepalives=0.  The remaining parameters, where supported,
>> can be used to adjust how often keepalives are sent and how many
>> can be lost before the connection is broken.

> There isn't any need at at all for this. We can already add options on
> the libpq connection line.

> options = '-o tcp_keepalives_idle=X
> tcp_keepalives_interval=Y
> tcp_keepalives_count=Z'

Huh?  The above is 100% fanciful; there was no code in libpq or anywhere
else that would have processed such a thing.

The bigger picture is that this patch is needed, not only for
walreceiver but for many other purposes --- the feature has been
requested repeatedly over the years and was already in the 9.1
commitfest queue.  We moved it up because it seemed fairly important for
walreceiver's purposes, but it would have gotten done in the very near
future anyway.
        regards, tom lane