Hi,
When reading the code of rel_max_parallel_hazard_for_modify in 0001.
I thought there are so many places call table_close().
Personally, It's a little confused to me.
Do you think it's better to do the table_open/close outside of rel_max_parallel_hazard_for_modify ?
Like:
static bool rel_max_parallel_hazard_for_modify(Relation rel,
CmdType command_type,
max_parallel_hazard_context *context);
...
Relation relation = table_open(rte->relid, NoLock);
(void) rel_max_parallel_hazard_for_modify(relation, parse->commandType, &context);
table_close(relation, NoLock);
And we seems do not need the lockmode param with the above define.
Best regards,
houzj