Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
От
Petr Jelinek
Тема
Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Дата
Msg-id
051E2C40-14DF-4AE4-9273-A9A42CDAB5C2@enterprisedb.com
Ответ на
Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.] (Robert Haas)
Список
Дерево обсуждения
Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.] Petr Jelinek <petr.jelinek@enterprisedb.com>
> On 7. 4. 2022, at 17:19, Robert Haas wrote: > > On Tue, Apr 5, 2022 at 10:17 AM Tom Lane wrote: >> What I think you need to do is: >> >> 1. In the back branches, revert delayChkpt to its previous type and >> semantics. Squeeze a separate delayChkptEnd bool in somewhere >> (you can't change the struct size either ...). >> >> 2. In HEAD, rename the field to something like delayChkptFlags, >> to ensure that any code touching it has to be inspected and updated. > > Here are patches for master and v14 to do things this way. Comments? Yeah I think this should do it (compilers should warn on master even without the rename, but who notices that right? :) ) Thanks, Petr
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата: