Re: client-side fsync() error handling

On 2020-02-12 06:28, Michael Paquier wrote:
> Now, don't we need to care about durable_rename() and make the
> panic-like failure an optional choice?  From what I can see, this
> routine is used now in the backend for pg_basebackup to rename
> temporary history files or partial WAL segments.

durable_rename() calls fsync_fname(), so it would be covered by this 
change.  The other file access calls in there can be handled by normal 
error handling, I think.  Is there any specific scenario you have in mind?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services