diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index e8779dc..ee27a58 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++ b/doc/src/sgml/ref/create_subscription.sgml @@ -437,7 +437,6 @@ CREATE SUBSCRIPTION subscription_namefalse. - If the subscriber-side column is also a generated column then this option has no effect; the subscriber column will be filled as normal with the diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 75a52ce..663015d 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -6609,12 +6609,12 @@ describeSubscriptions(const char *pattern, bool verbose) appendPQExpBuffer(&buf, ", subskiplsn AS \"%s\"\n", gettext_noop("Skip LSN")); + + /* include_generated_columns is only supported in v18 and higher */ if (pset.sversion >= 170000) appendPQExpBuffer(&buf, ", subincludegencols AS \"%s\"\n", gettext_noop("include_generated_columns")); - - // include_generated_columns } /* Only display subscriptions in current database. */ diff --git a/src/test/subscription/t/011_generated.pl b/src/test/subscription/t/011_generated.pl index 92b3dbf..cbd5015 100644 --- a/src/test/subscription/t/011_generated.pl +++ b/src/test/subscription/t/011_generated.pl @@ -24,7 +24,7 @@ $node_publisher->safe_psql('postgres', "CREATE TABLE tab1 (a int PRIMARY KEY, b int GENERATED ALWAYS AS (a * 2) STORED)" ); -# publisher-side tab2 has generated col 'b' but subscriber-side tab2 has NON-gnerated col 'b'. +# publisher-side tab2 has generated col 'b' but subscriber-side tab2 has NON-generated col 'b'. $node_publisher->safe_psql('postgres', "CREATE TABLE tab2 (a int PRIMARY KEY, b int GENERATED ALWAYS AS (a * 2) STORED)" );