Re: Adding REPACK [concurrently]

Поиск
Список
Период
Сортировка
От Mihail Nikalayeu
Тема Re: Adding REPACK [concurrently]
Дата
Msg-id CADzfLwWS6Ukme5uhv9=1ZyyG=D5Bp0dE+zGn=qcfGV=jSY6mpw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Adding REPACK [concurrently]  (Mihail Nikalayeu <mihailnikalayeu@gmail.com>)
Список pgsql-hackers
Hello, Antonin!

Some comments for 0003:

 > /* allocate in transaction context */
It may be any context now, because it is a function now.

> result = CopySnapshot(snapshot);

> /* Restore the original values so the source is intact. */
> snapshot->xip = oldxip;
> snapshot->xcnt = oldxcnt;

I think it is worth to call pfree(newxip) here.

> "This difference does has no impact"

should be "This difference has no impact"?


Best regards,
Mikhail.



В списке pgsql-hackers по дате отправления: